[GH-54] Fix golang releases without patch version not being installed #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
syndbg
force-pushed
the
gh-34-fix-semantic-versioning
branch
2 times, most recently
from
cc3bdfa to
ce5320a
Compare
syndbg
changed the title
syndbg
force-pushed
the
gh-34-fix-semantic-versioning
branch
2 times, most recently
from
fa2487d to
6d45b07
Compare
This workarounds two sides' choices. First Golang does not release major versions, e.g `1.11.0` with the patch version of `0`. Second goenv only adds installable definitions with patch version as per semantic versioning by the book (arguably). The solution here is when provided with a install definition such as `1.11` to add a patch version of `0` automatically and the result will be a search for install definition `1.11.0`.
syndbg
force-pushed
the
gh-34-fix-semantic-versioning
branch
from
6d45b07 to
6685afe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This workarounds two sides' choices.
First Golang does not release major versions,
e.g
1.11.0with the patch version of0.Second goenv only adds installable definitions
with patch version as per semantic versioning by the book (arguably).
The solution here is when provided with a install definition such as
1.11to add a patch version of
0automatically and the result will be a searchfor install definition
1.11.0.