Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

shim for go1.11 is named go1.11.0 which does not match binary own opinion on its version #54

Closed
webervin opened this issue Sep 19, 2018 · 3 comments
Closed

shim for go1.11 is named go1.11.0 which does not match binary own opinion on its version #54

webervin opened this issue Sep 19, 2018 · 3 comments

Comments

@webervin
Copy link

while it feels like bug in go, to omit .0 from version, I believe you should match version numbers exactly. Integration tests that put version into .go-version and try to parse that version back from go version output do fail due to this mismatch.

goenv install 1.11
go-build: definition not found: 1.11

The following versions contain `1.11' in the name:
  1.11.0
  1.11beta2
  1.11beta3
  1.11rc1
  1.11rc2

echo '1.11.0' > .go-version
go version
go version go1.11 linux/amd64
@syndbg syndbg added bug Hacktoberfest Hacktoberfest-applicable issue labels Oct 3, 2018
@syndbg syndbg removed Hacktoberfest Hacktoberfest-applicable issue bug labels Dec 29, 2018
@syndbg
Copy link
Member

syndbg commented Dec 29, 2018

I understand, however keeping it correct according to semver is more important to me.

I actually think we should've had 1.11.0{beta2,beta3,rc1,rc2}` to be consistent.

@syndbg syndbg closed this as completed Dec 29, 2018
@syndbg syndbg reopened this Dec 29, 2018
@syndbg
Copy link
Member

syndbg commented Dec 29, 2018

Didn't mean to close issue w/o consensus.

Since I'm refreshing the test suite in #62 I'll check if we can "hack" around matching 1.11 also a 1.11.0 and/or latest patch version.

syndbg added a commit that referenced this issue Apr 9, 2019
@syndbg
[GH-54] Fix golang releases without patch not being installed
0b5e4a2 
This workarounds two sides' choices.

First Golang does not release major versions,
 e.g `1.11.0` with the patch version of `0`.

Second goenv only adds installable definitions
 with patch version as per semantic versioning by the book (arguably).

The solution here is when provided with a install definition such as `1.11`
 to add a patch version of `0` automatically and the result will be a search
 for install definition `1.11.0`.
syndbg added a commit that referenced this issue Apr 9, 2019
@syndbg
[GH-54] Fix golang releases without patch version not being installed
cc3bdfa 
This workarounds two sides' choices.

First Golang does not release major versions,
 e.g `1.11.0` with the patch version of `0`.

Second goenv only adds installable definitions
 with patch version as per semantic versioning by the book (arguably).

The solution here is when provided with a install definition such as `1.11`
 to add a patch version of `0` automatically and the result will be a search
 for install definition `1.11.0`.
syndbg added a commit that referenced this issue Apr 9, 2019
@syndbg
[GH-54] Fix golang releases without patch version not being installed
ce5320a 
This workarounds two sides' choices.

First Golang does not release major versions,
 e.g `1.11.0` with the patch version of `0`.

Second goenv only adds installable definitions
 with patch version as per semantic versioning by the book (arguably).

The solution here is when provided with a install definition such as `1.11`
 to add a patch version of `0` automatically and the result will be a search
 for install definition `1.11.0`.
syndbg added a commit that referenced this issue Apr 9, 2019
@syndbg
[GH-54] Fix golang releases without patch version not being installed
fa2487d 
This workarounds two sides' choices.

First Golang does not release major versions,
 e.g `1.11.0` with the patch version of `0`.

Second goenv only adds installable definitions
 with patch version as per semantic versioning by the book (arguably).

The solution here is when provided with a install definition such as `1.11`
 to add a patch version of `0` automatically and the result will be a search
 for install definition `1.11.0`.
syndbg added a commit that referenced this issue Apr 14, 2019
@syndbg
[GH-54] Fix golang releases without patch version not being installed
6d45b07 
This workarounds two sides' choices.

First Golang does not release major versions,
 e.g `1.11.0` with the patch version of `0`.

Second goenv only adds installable definitions
 with patch version as per semantic versioning by the book (arguably).

The solution here is when provided with a install definition such as `1.11`
 to add a patch version of `0` automatically and the result will be a search
 for install definition `1.11.0`.
syndbg added a commit that referenced this issue Apr 14, 2019
@syndbg
[GH-54] Fix golang releases without patch version not being installed
6685afe 
This workarounds two sides' choices.

First Golang does not release major versions,
 e.g `1.11.0` with the patch version of `0`.

Second goenv only adds installable definitions
 with patch version as per semantic versioning by the book (arguably).

The solution here is when provided with a install definition such as `1.11`
 to add a patch version of `0` automatically and the result will be a search
 for install definition `1.11.0`.
syndbg added a commit that referenced this issue Apr 14, 2019
@syndbg
Merge pull request #75 from syndbg/gh-34-fix-semantic-versioning
cc5bf29 
[GH-54] Fix golang releases without patch version not being installed
@syndbg
Copy link
Member

syndbg commented Apr 14, 2019

Addressed in https://github.com/syndbg/goenv/releases/tag/2.0.0beta9 🎉

@syndbg syndbg closed this as completed Apr 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@webervin @syndbg