Remove GOROOT when system's go #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kosukemori Thank you for the PR. Give me a day or two to think about the approach you chose. On first read it sounds good. |
|
Took my sweet time, I'm happy with the approach |
|
Thanks! |
syndbg
added a commit
that referenced
this pull request
Apr 14, 2019
[GH-54] Fix golang releases without patch version not being installed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will solve #26
The followings are the points of this PR, but I'm not sure whether it's perfectly correct.
Point1: If
$(goenv version) == system, don't setGOROOTinlibexec/goenv-exec. BecauseGOROOTof system's go depends on how users installed go in system.Point2: It's not necessary to set
GOROOTin the script ofgoenv init -GOROOTby the same reason in Point1.GOROOTwill be set in here. So it's not necessary ingoenv init -