Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support multiple languages and add Chinese translation #1058

Merged

Conversation

misitebao
Copy link
Contributor

@misitebao misitebao commented Mar 13, 2023

It mainly solves the problems mentioned in Help site supports multiple languages, and the specific work is as follows:

  • Add multilingual capabilities to the documentation site
  • Add Crowdin CLI tool and workflow
  • Add Simplified Chinese translation (60%)

Resolve: #1057

Preview: https://misitebao-taskfile-git-feature-1057-support-mu-5d0af6-misitebao.vercel.app/

@misitebao misitebao force-pushed the feature/1057-support-multiple-languages branch 3 times, most recently from 5e438ee to 669e8a4 Compare March 15, 2023 10:36
@andreynering andreynering added area: translation Changes related to translated documents. area: docs Changes related to documentation. labels Mar 15, 2023
@misitebao misitebao force-pushed the feature/1057-support-multiple-languages branch 3 times, most recently from 76bb3b4 to d166dce Compare March 16, 2023 04:25
@misitebao misitebao marked this pull request as ready for review March 16, 2023 04:36
@misitebao misitebao force-pushed the feature/1057-support-multiple-languages branch 4 times, most recently from 1eaa884 to 1cd0b19 Compare March 16, 2023 13:27
Copy link
Member

@andreynering andreynering left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @misitebao,

First of all, thanks for your work setting all this up! In general this seems to be working very well for me, and it's a good addition to the website!

Something I noticed: when running the Docusaurus server locally the translations are not being generated for some reason, and we get a 404 when trying to see any translated page. When running task docs:build everything works perfectly, though, so probably not a big deal for now.

Screenshot 2023-03-16 at 22 35 32

Let me know once you think you have finished and this is ready to be merged. I may do a few adjustments once in master.

docs/Taskfile.yml Outdated Show resolved Hide resolved
docs/Taskfile.yml Outdated Show resolved Hide resolved
docs/crowdin.yml Outdated Show resolved Hide resolved
@misitebao misitebao force-pushed the feature/1057-support-multiple-languages branch from 1cd0b19 to 3669372 Compare March 17, 2023 03:31
@misitebao
Copy link
Contributor Author

misitebao commented Mar 17, 2023

Hi @andreynering,

Something I noticed: when running the Docusaurus server locally the translations are not being generated for some reason, and we get a 404 when trying to see any translated page. When running task docs:build everything works perfectly, though, so probably not a big deal for now.

This is because when using docusaurus start, you cannot start all language sites at the same time, if you want to access a specific language, please refer to the documentation: https://docusaurus.io/docs/i18n/tutorial#start-your-site

If you want to preview all languages at the same time, you can do this:

task build
task preview

Let me know once you think you have finished and this is ready to be merged. I may do a few adjustments once in master.

The scope of functions involved in this PR has basically been completed, if you think there is no problem, you can merge it at any time.

For the remaining untranslated documents, after adding a new translation, you can manually trigger the .github/workflows/sync-translated-documents.yml and submit the PR automatically. At the same time, it is also a good time to test whether the function of automatic synchronization of Action is normal.

@misitebao misitebao requested a review from andreynering March 17, 2023 03:36
@misitebao misitebao force-pushed the feature/1057-support-multiple-languages branch 2 times, most recently from 3a91b31 to 5a6ec28 Compare March 17, 2023 14:08
@misitebao misitebao force-pushed the feature/1057-support-multiple-languages branch from 5a6ec28 to 4593d8c Compare March 17, 2023 14:19
@andreynering andreynering merged commit eead5f4 into go-task:master Mar 21, 2023
andreynering added a commit that referenced this pull request Mar 21, 2023
@andreynering
Copy link
Member

Thanks @misitebao!

@misitebao misitebao deleted the feature/1057-support-multiple-languages branch March 21, 2023 06:39
@pd93 pd93 mentioned this pull request Jul 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: docs Changes related to documentation. area: translation Changes related to translated documents.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Help site supports multiple languages.
2 participants