-
-
Notifications
You must be signed in to change notification settings - Fork 624
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support multiple languages and add Chinese translation #1058
feat: support multiple languages and add Chinese translation #1058
Conversation
5e438ee
to
669e8a4
Compare
76bb3b4
to
d166dce
Compare
1eaa884
to
1cd0b19
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @misitebao,
First of all, thanks for your work setting all this up! In general this seems to be working very well for me, and it's a good addition to the website!
Something I noticed: when running the Docusaurus server locally the translations are not being generated for some reason, and we get a 404 when trying to see any translated page. When running task docs:build
everything works perfectly, though, so probably not a big deal for now.
Let me know once you think you have finished and this is ready to be merged. I may do a few adjustments once in master.
1cd0b19
to
3669372
Compare
Hi @andreynering,
This is because when using If you want to preview all languages at the same time, you can do this:
The scope of functions involved in this PR has basically been completed, if you think there is no problem, you can merge it at any time. For the remaining untranslated documents, after adding a new translation, you can manually trigger the |
3a91b31
to
5a6ec28
Compare
5a6ec28
to
4593d8c
Compare
Thanks @misitebao! |
It mainly solves the problems mentioned in Help site supports multiple languages, and the specific work is as follows:
Resolve: #1057
Preview: https://misitebao-taskfile-git-feature-1057-support-mu-5d0af6-misitebao.vercel.app/