fix: wrong working directory with USER_WORKING_DIR in included Taskfi… #1274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…les (go-task#1250) When using `dir: '{{.USER_WORKING_DIR}}'` in an included task, the working directory was set incorrectly by concatenating the base Taskfile directory and the USER_WORKING_DIR.
andreynering
added a commit
that referenced
this pull request
Aug 18, 2023
andreynering
added a commit
that referenced
this pull request
Aug 18, 2023
andreynering
added a commit
that referenced
this pull request
Aug 26, 2023
andreynering
added a commit
that referenced
this pull request
Aug 26, 2023
andreynering
added a commit
that referenced
this pull request
Aug 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…les (#1250)
When using
dir: '{{.USER_WORKING_DIR}}'in an included task, the working directory was set incorrectly by concatenating the base Taskfile directory and the USER_WORKING_DIR.#1205 might be the same problem and is possibly fixed too, but I haven't tested the patch on Windows.
Also, while this patch fixes the symptom, there a better place to implement the fix would be where the USER_WORKING_DIR gets concatenated in the first place, but I wasn't able the find that in the time a had available. At least this patch and the included test case should point you in the right direction.