Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: make sure USER_WORKING_DIR works corrently with includes #1309

Merged
merged 1 commit into from
Aug 26, 2023
Merged

fix: make sure USER_WORKING_DIR works corrently with includes #1309

merged 1 commit into from
Aug 26, 2023

Conversation

andreynering
Copy link
Member

@andreynering andreynering commented Aug 18, 2023 •
edited
Loading

Closes #1046
Closes #1205
Closes #1250
Closes #1293
Closes #1274
Closes #1312
Also reported at this Discord thread

@andreynering andreynering added the area: variables Changes related to variables. label Aug 18, 2023
@andreynering andreynering self-assigned this Aug 18, 2023
andreynering added a commit that referenced this pull request Aug 18, 2023
@andreynering @fmnet
fix: make sure USER_WORKING_DIR works corrently with includes
ae41091 
Closes #1046
Closes #1205
Closes #1250
Closes #1293
Closes #1274
Closes #1309

Co-authored-by: Marcus Spading <ms@fragmentum.net>
@andreynering andreynering requested a review from pd93 August 18, 2023 01:03
@andreynering andreynering mentioned this pull request Aug 18, 2023
Closed
pd93
pd93 approved these changes Aug 22, 2023
View reviewed changes
Copy link
Member

@pd93 pd93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay getting to this. I think there is still the potential for a better long-term fix for this as I mentioned in #1046, but I still don't know what it is 😆 This works well for now.

andreynering added a commit that referenced this pull request Aug 26, 2023
@andreynering @fmnet
fix: make sure USER_WORKING_DIR works corrently with includes
12f81ef 
Closes #1046
Closes #1205
Closes #1250
Closes #1293
Closes #1274
Closes #1309
Closes #1312

Co-authored-by: Marcus Spading <ms@fragmentum.net>
@andreynering @fmnet
fix: make sure USER_WORKING_DIR works corrently with includes
9b06d80 
Closes #1046
Closes #1205
Closes #1250
Closes #1293
Closes #1274
Closes #1309
Closes #1312

Co-authored-by: Marcus Spading <ms@fragmentum.net>
@andreynering andreynering enabled auto-merge (squash) August 26, 2023 21:06
@andreynering andreynering merged commit e96712b into main Aug 26, 2023
@andreynering andreynering deleted the fix/user-working-dir branch August 26, 2023 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pd93 pd93 pd93 approved these changes

Assignees

@andreynering andreynering

Labels
area: variables Changes related to variables.
Projects
None yet
Milestone
No milestone
2 participants
@andreynering @pd93