-
Notifications
You must be signed in to change notification settings - Fork 174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Add BIP 151 support #449
Conversation
git-subtree-dir: cppForSwig/chacha20poly1305 git-subtree-split: d7d214b879a65529739f2d526bf9d36c2c57128c
…g/chacha20poly1305'
- Integrate Jona Schnelli's ChaCha20Poly1305 library into our code. - Miscellaneous build system cleanup.
Confirmed that the library compiles on Ubuntu 17.10. Will try macOS later. Windows will have to wait. I also want to point out one specific change I made in Makefile.am. ArmoryDB was listed under |
Per our discussion, I'll be backing out the libsecp256k1 commit and adding libbtc, which includes libsecp256k1. libbtc technically isn't part of this commit but we're planning to use it as a drop-in replacement for Crypto++ eventually (0.98???). We might as well get it in the build system now. |
git-subtree-dir: cppForSwig/libbtc git-subtree-split: a8506a03718257a7e6797bac4eafee0f60abb22b
libbtc has been added. However, for now it may not be possible to build libbtc on Windows. This PR is designed to allow the code to compile using Visual Studio 2015. It'll need a push (and a rebase) if it's going to be committed, otherwise somebody will have to fix everything up down the road. For now, I'm just going to build libbtc on Linux and macOS. If it becomes an issue, I can just compile libsecp256k1 until we're ready for Armory to use libbtc and replace Crypto++. |
2da2549
to
536a4e1
Compare
Also do a bit of random cleanup of Autotools files.
a1a4db1
to
c084ef9
Compare
Incoming turbulence. Rebase is doing some weird things. Am thinking it's best to just delete this branch and start fresh. I'll try to avoid having to close this PR. |
Initial step: In Git, submodules and subtrees seem to have fundamental issues with each other that prevent subtrees from being used alongside submodules. Delete the FCGI submodule, re-add it as a subtree, and add Jonas Schnelli's ChaCha20Poly1305 library.
Much work remains to be done. The list includes but is not limited to: