Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Autotools setup #458

Merged
merged 1 commit into from
Feb 15, 2018
Merged

Update Autotools setup #458

merged 1 commit into from
Feb 15, 2018

Conversation

droark
Copy link

@droark droark commented Feb 10, 2018

  • Move root autogen.sh to the one used by Bitcoin Core (very simple, unlike the current autogen.sh).
  • Remove extra uses of C++11 flags.
  • Silence make output unless "V=1" is used when using make.
  • Rearrange some lines so that everything's a bit more cohesive, including moving #include files to CPPFLAGS (can be accessed in C and C++, and preprocessor means the effective output doesn't change).
  • Further enforce C++11 compilation.
  • m4 --> build-aux/m4
  • Upgrade the C++11 M4 file to fix an Autotools warning, and include new files as needed to keep autoreconf happy.
  • Set the minimum Automake version to 1.11 due to silent rule macro requirements. (1.11 came out in 2009, and I doubt Armory supports any pre-1.11 systems.)
  • Add a patch to ax_gcc_x86_cpu_supports.m4 to silence an Autoconf warning ("serial 3" version with one change: AC_RUN_IFELSE --> AC_COMPILE_IFELSE).
  • Update macOS build script to give users the ability to get verbose make output.

@droark droark mentioned this pull request Feb 10, 2018
Closed
@droark
Copy link
Author

droark commented Feb 10, 2018

Meant to work in conjunction with this libfcgi PR.

@droark droark mentioned this pull request Feb 10, 2018
Merged
@droark
Copy link
Author

droark commented Feb 10, 2018

This is mostly tested in dev. I can only go so far due to dev being fundamentally broken (for now) in Linux and macOS but what I saw looked good. If things are broken even more, I'll just patch it more as needed. I'd like to get this pulled ASAP so that the BIP 151 PR can sync up and get the new libraries properly integrated.

@droark droark force-pushed the dev-makecleanup branch 2 times, most recently from 8a982e7 to 69aa9d2 Compare February 13, 2018 00:35
@droark droark mentioned this pull request Feb 13, 2018
Open
@droark
Update Autotools setup
df920a7 
- Move root autogen.sh to the one used by Bitcoin Core (very simple, unlike the current autogen.sh).
- Remove extra uses of C++11 flags.
- Silence make output unless "V=1" is used when using make.
- Rearrange some lines so that everything's a bit more cohesive, including moving #include files to CPPFLAGS (can be accessed in C and C++, and preprocessor means the effective output doesn't change).
- Further enforce C++11 compilation.
- m4 --> build-aux/m4
- Upgrade the C++11 M4 file to fix an Autotools warning, and include new files as needed to keep autoreconf happy.
- Set the minimum Automake version to 1.11 due to silent rule macro requirements. (1.11 came out in 2009, and I doubt Armory supports any pre-1.11 systems.)
- Add a patch to ax_gcc_x86_cpu_supports.m4 to silence an Autoconf warning ("serial 3" version with one change: AC_RUN_IFELSE --> AC_COMPILE_IFELSE).
- Update macOS build script to give users the ability to get verbose make output.
@goatpig goatpig merged commit df920a7 into goatpig:dev Feb 15, 2018
@droark droark deleted the dev-makecleanup branch February 15, 2018 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@droark @goatpig