-
Notifications
You must be signed in to change notification settings - Fork 338
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #450: Adds new function for generating a shorter form prival string. #457
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## latest #457 +/- ##
==========================================
+ Coverage 90.35% 90.56% +0.20%
==========================================
Files 47 47
Lines 4374 4386 +12
Branches 586 586
==========================================
+ Hits 3952 3972 +20
+ Misses 287 280 -7
+ Partials 135 134 -1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is off to a good start! You'll need to add your new function to src/windows/stumpless.def
for the Windows tests to pass.
Review the issue and make sure that you understand the format. This is different from the stumpless_get_prival_string
format: the STUMPLESS
prefixes aren't needed and the string should be in lowercase.
Hello @Jackb18b and @goatshriek. |
With no response from the original author, I think you're safe to bring it across the finish line. Abandoned PRs are not uncommon, particularly around Hacktoberfest. |
I've added the fixes on another PR (#476) due to privilege issues on the original fork. |
This work was finished by #476. The original author here has been given co-author credit, as the work was based on this one. |
Adds a new function for a condensed and logger-standard prival string.