Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #450: Adds new function for generating a shorter form prival string. #457

Closed
wants to merge 2 commits into from

Conversation

Jackb18b
Copy link
Contributor

@Jackb18b Jackb18b commented Oct 3, 2024

Adds a new function for a condensed and logger-standard prival string.

@goatshriek goatshriek self-assigned this Oct 3, 2024
Copy link

codecov bot commented Oct 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.56%. Comparing base (1bd3333) to head (a5d52c5).

Additional details and impacted files
@@            Coverage Diff             @@
##           latest     #457      +/-   ##
==========================================
+ Coverage   90.35%   90.56%   +0.20%     
==========================================
  Files          47       47              
  Lines        4374     4386      +12     
  Branches      586      586              
==========================================
+ Hits         3952     3972      +20     
+ Misses        287      280       -7     
+ Partials      135      134       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Owner

@goatshriek goatshriek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is off to a good start! You'll need to add your new function to src/windows/stumpless.def for the Windows tests to pass.

Review the issue and make sure that you understand the format. This is different from the stumpless_get_prival_string format: the STUMPLESS prefixes aren't needed and the string should be in lowercase.

src/prival.c Outdated Show resolved Hide resolved
src/prival.c Outdated Show resolved Hide resolved
test/function/prival.cpp Outdated Show resolved Hide resolved
@m3g4d1v3r
Copy link
Contributor

Hello @Jackb18b and @goatshriek.
Can I co-author this PR? If you don't mind, I can make some commits after the old ones in order to let the PR pass the tests.

@goatshriek
Copy link
Owner

With no response from the original author, I think you're safe to bring it across the finish line. Abandoned PRs are not uncommon, particularly around Hacktoberfest.

@m3g4d1v3r
Copy link
Contributor

I've added the fixes on another PR (#476) due to privilege issues on the original fork.

@goatshriek
Copy link
Owner

This work was finished by #476. The original author here has been given co-author credit, as the work was based on this one.

@goatshriek goatshriek closed this Nov 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants