450 stumpless get priority string

[m3g4d1v3r]

This is a continuation from the other opened PR #457.

Since I don't have the permissions to commit to the other contributor's fork, I've decided to cherry pick them and publish a new PR.

I hope this is the proper way to do it.

Please, let me know if any adjustments are needed in this branch.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.22%. Comparing base (b638f77) to head (349de16).
Report is 2 commits behind head on latest.

Additional details and impacted files

@@            Coverage Diff             @@
##           latest     #476      +/-   ##
==========================================
- Coverage   90.40%   90.22%   -0.18%     
==========================================
  Files          47       47              
  Lines        4388     4410      +22     
  Branches      588      592       +4     
==========================================
+ Hits         3967     3979      +12     
- Misses        286      288       +2     
- Partials      135      143       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[goatshriek]

Excellent work! There is one last change needed: please add a test that passes and invalid prival in, and add some error handling to ensure the response is sane. I personally think a NULL response in this case makes the most sense, but since the facility and severity string functions do not do this, I will defer to you for this change. Before the v3.0.0 release I will likely refactor all of them to return NULL in the event of an error so that the scenario is more clear.

The deadlock was not related to your changes, and is the second time I've seen it. I created #477 to capture the logs and remind myself to go back and look at this, but for now I only mention it to you as something you don't need to worry about.

[m3g4d1v3r]

I've just added a commit with invalid privals checking and testing.

[goatshriek]

Just a tweak on how an invalid prival is checked, and this should be good to go.

[goatshriek]

Thanks very much for finishing the resolution for this one!