Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add column to location #295

Merged
merged 4 commits into from
Jul 22, 2021
Merged

Add column to location #295

merged 4 commits into from
Jul 22, 2021

Conversation

sim642
Copy link
Member

@sim642 sim642 commented Jul 21, 2021 •
edited
Loading

Compatibility for goblint/cil#42.

TODO

  • Update goblint-cil opam pin after it's merged there.

@sim642 sim642 mentioned this pull request Jul 21, 2021
Merged
3 tasks
@michael-schwarz
Copy link
Member

LGTM! I think we can update the pin and merge this.

@sim642
Copy link
Member Author

sim642 commented Jul 22, 2021

I'll go ahead and do that, but it's still open how we want to use and expose this extra information. Because I didn't Cil.d_loc to include the column number in the output, it's not outputted anywhere. So there's still things to be done, but I'll open a separate issue to discuss that.

@sim642 sim642 merged commit 6759b40 into master Jul 22, 2021
@sim642 sim642 deleted the line-offset branch July 22, 2021 10:15
@sim642 sim642 mentioned this pull request Jul 22, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
feature usability
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sim642 @michael-schwarz