Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add column to location #42

Merged
merged 6 commits into from
Jul 22, 2021
Merged

Add column to location #42

merged 6 commits into from
Jul 22, 2021

Conversation

sim642
Copy link
Member

@sim642 sim642 commented Jul 16, 2021 •
edited
Loading

This would allow more precise locations in Goblint, particularly when multiple statements are on a single line.

TODO

  • Update d_loc? Potentially breaks a lot of Goblint scripts that try to parse locations and what would even be the format?
  • Update compareLoc etc.
  • Update Goblint in parallel (Add column to location analyzer#295).

jerhard
jerhard reviewed Jul 16, 2021
View reviewed changes
src/ocamlutil/errormsg.mli Outdated Show resolved Hide resolved
@sim642 sim642 changed the title Add line offsets to locations Add column to location Jul 21, 2021
@sim642 sim642 marked this pull request as ready for review July 21, 2021 08:30
@sim642 sim642 mentioned this pull request Jul 21, 2021
Merged
1 task
@sim642
Copy link
Member Author

sim642 commented Jul 21, 2021

I renamed it from lineoffset to column now since that should be a more standard name.

@michael-schwarz michael-schwarz merged commit 208d2a2 into develop Jul 22, 2021
sim642 added a commit to goblint/analyzer that referenced this pull request Jul 22, 2021
@sim642
Pin goblint-cil to merged line-offset changes
7cfd39c 
goblint/cil#42
@vogler vogler mentioned this pull request Jul 27, 2021
Closed
@sim642 sim642 deleted the line-offset branch May 30, 2022 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jerhard jerhard jerhard left review comments

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sim642 @jerhard @michael-schwarz