Assorted cleanups and improvements #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And no other addresses. This avoids firewall nagging on macOS. We were already configuring the webhook server to listen on the loopback interface only, but this isn't working due to a bug in controller-runtime. Fixed by kubernetes-sigs/controller-runtime#322.
* Duplicate kustomize instructions * `make clean` removed directory that never exists
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog
4dbe7f2: More idiomatic ginkgo recursive invocation
29d7be8: Support short help flag
83b4614: Integration test servers listen on localhost
And no other addresses. This avoids firewall nagging on macOS. We were
already configuring the webhook server to listen on the loopback
interface only, but this isn't working due to a bug in
controller-runtime. Fixed by
kubernetes-sigs/controller-runtime#322.
af4c1e8: Remove small redundant things
make cleanremoved directory that never exists