Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Webhook server uses its configured host if set #322

Merged
merged 1 commit into from
Feb 15, 2019
Merged

🐛 Webhook server uses its configured host if set #322

merged 1 commit into from
Feb 15, 2019

Conversation

craigfurman
Copy link
Contributor

@craigfurman craigfurman commented Feb 11, 2019 •
edited
Loading

Update: Since this PR was originally made, the ability to configure the webhook server host was removed from master. Rather than fixing a bug, this PR now introduces a new minor, non-breaking feature.

I would still like to see this merged if possible, as it's handy for integration testing using the webhook server on developer machines that are (perhaps a little overzealously) configured with a firewall to loudly complain if new server processes begin listening on non-loopback interfaces.

The webhook server can be configured with a host to bind to, defaulting to all IPs (empty string) if not set. This was not actually used.

@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Feb 11, 2019
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 11, 2019
@craigfurman
Copy link
Contributor Author

I just signed the CLA

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Feb 11, 2019
craigfurman added a commit to gocardless/theatre that referenced this pull request Feb 11, 2019
@craigfurman
Integration test servers listen on localhost
83b4614 
And no other addresses. This avoids firewall nagging on macOS. We were
already configuring the webhook server to listen on the loopback
interface only, but this isn't working due to a bug in
controller-runtime. Fixed by
kubernetes-sigs/controller-runtime#322.
DirectXMan12
DirectXMan12 suggested changes Feb 12, 2019
View reviewed changes
Copy link
Contributor

@DirectXMan12 DirectXMan12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

comments inline (never use strings.Join or fmt.Sprintf to format addresses)

pkg/webhook/server.go Outdated
serveFn := func() {
s.httpServer = &http.Server{
Addr: fmt.Sprintf(":%v", s.Port),
Addr: fmt.Sprintf("%s:%d", host, s.Port),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This breaks on IPv6. Use net.JoinHostPort instead.

@craigfurman craigfurman mentioned this pull request Feb 12, 2019
Merged
@craigfurman
Copy link
Contributor Author

Cheers, ready for another review now

@craigfurman
Copy link
Contributor Author

(and thanks for the speedy response!)

@DirectXMan12
Copy link
Contributor

needs rebase, otherwise looks good 👍

@craigfurman
Copy link
Contributor Author

Rebased. I've updated the top message to re-state what this PR does, because since I made it, upstream has removed the webhook server_test file, and removed the configurability of the host.

@mengqiy
Copy link
Member

mengqiy commented Feb 15, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 15, 2019
@mengqiy mengqiy added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 15, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: craigfurman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 02cc4d9 into kubernetes-sigs:master Feb 15, 2019
@craigfurman craigfurman mentioned this pull request Apr 22, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DirectXMan12 DirectXMan12 DirectXMan12 approved these changes

@droot droot Awaiting requested review from droot

Assignees

@mengqiy mengqiy

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@craigfurman @k8s-ci-robot @DirectXMan12 @mengqiy