Prevent -Wtype-limits warning on GCC 11 due to unsigned comparison
#1323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akien-mga
reviewed
Nov 30, 2023
akien-mga
approved these changes
Nov 30, 2023
dsnopek
force-pushed
the
gcc-type-limits-error
branch
from
418ce44
to
cad5be5
Compare
|
Hi David |
akien-mga
changed the title
-Wtype-limits warning on GCC 11 due to unsigned comparison
|
Thanks! |
|
Cherry-picking to 4.2 in #1372 |
|
Cherry-picking to 4.1 in #1373 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1322
I don't know if this is the best fix, it does what I wish GCC would do, which is just turn
unsigned_value >= 0intotrue:-)FYI, I'm not personally getting this error locally, even though I am using GCC 11.4 on Ubuntu 22.04, which is the same as the issue reporter. So, someone that's actually getting this error should confirm that this fixes it.