Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix expected argument count for call errors #1346

Merged
merged 1 commit into from
Jan 4, 2024

Conversation

AThousandShips
Copy link
Member

@AThousandShips AThousandShips commented Dec 30, 2023

godot-cpp version of:

Cherry picking for 4.2 as it was merged in 4.2 but not for 4.1 to match the engine where it was not cherry picked for 4.1

@AThousandShips AThousandShips added bug This has been identified as a bug topic:gdextension This relates to the new Godot 4 extension implementation cherrypick:4.2 labels Dec 30, 2023
@AThousandShips AThousandShips added this to the 4.3 milestone Dec 30, 2023
@AThousandShips AThousandShips requested a review from a team as a code owner December 30, 2023 12:24
Copy link
Collaborator

@dsnopek dsnopek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

The changes here appear to match the changes to binder_common.h in Godot. Looks good to me!

@dsnopek dsnopek merged commit 8d13acc into godotengine:master Jan 4, 2024
12 checks passed
@AThousandShips AThousandShips deleted the arg_fix branch January 4, 2024 14:37
@dsnopek
Copy link
Collaborator

dsnopek commented Jan 22, 2024

Cherry-picking to 4.2 in #1372

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This has been identified as a bug topic:gdextension This relates to the new Godot 4 extension implementation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Confusing error message when signal calls callable with wrong number of arguments
2 participants