-
-
Notifications
You must be signed in to change notification settings - Fork 604
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cherry-picks for the godot-cpp 4.3 branch - 3rd batch #1695
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsnopek
added
bug
This has been identified as a bug
enhancement
This is an enhancement on the current functionality
labels
Jan 27, 2025
This was referenced Jan 27, 2025
Merged
Ivorforce
approved these changes
Jan 28, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested 50cc828 with my 4.3 GDExtension. Compiled and ran fine!
paddy-exe
approved these changes
Jan 28, 2025
… the wrong size (cherry picked from commit 1e169bb)
(cherry picked from commit 91833c8)
(cherry picked from commit 5f7cf05)
The use of .components is deprecated. (cherry picked from commit 23c9d41)
(cherry picked from commit 7f02301)
A global alias of godot::real_t is defined for backward compatibility (cherry picked from commit 450c3d6)
(cherry picked from commit c1524f7)
…e'. If a user attempts to call either of these it will introduce a linker error and it may not be immediately clear to them why. Also, variant interpolation can already be accessed via 'UtilityFunctions::lerp', making at least the interpolate function unecessary here. (cherry picked from commit 42a35a1)
(cherry picked from commit 2004af6)
Due to how caches are accessed this cache is almost useless, it only matters if it is from the same branch or a base branch, and is identical between branches, so caching it just clutters the build cache (cherry picked from commit 1e3b24f)
(cherry picked from commit ac466e4)
(cherry picked from commit 9943675)
…_verbose()` (cherry picked from commit 47d9cb9)
This allows removing dependencies that are not explicitly unused by the gdextension being built and is implemented using an intermediate json API file with the methods and classes stripped (i.e. without touching the file generators). (cherry picked from commit c4f1abe)
(cherry picked from commit 0cfe01e)
(cherry picked from commit bd3cf47)
…only 32-bit (cherry picked from commit 7576dc5)
dsnopek
force-pushed
the
4.3-cherrypicks-3
branch
from
January 28, 2025 16:37
50cc828
to
08e4c89
Compare
@Ivorforce @paddy-exe Thanks for reviewing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug
This has been identified as a bug
enhancement
This is an enhancement on the current functionality
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The 3rd batch of PR's marked with
cherrypick:4.3