Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove note in Submitting to Asset Library #10090

Merged
merged 1 commit into from
Oct 16, 2024

Conversation

tetrapod00
Copy link
Contributor

@tetrapod00 tetrapod00 commented Oct 15, 2024

Removes a note which encourages users to message AssetLib reviewers for faster approval.

Previously, removed only the mention of discord from the note. Previous description:
The discord should not be used for development purposes, and this note makes an assumption that AssetLib reviewers are present in the official discord, which may no longer be true. This note was originally 7 years ago, when "official discord server" referred to what is now the Godot Cafe discord.

Arguably the note should be removed entirely, or replaced with something like:

If you have any questions about the asset review process, you can ask in the Godot Contributors chat.

Including a note in the official submission process to bother the reviewers seems possibly incorrect.

Copy link
Contributor

@skyace65 skyace65 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with removing this note entirely. I don't think we should be encouraging people to message reviewers to try and skip to the front of the line.

@skyace65 skyace65 added enhancement area:community Issues and PRs related to the Community section of the documentation labels Oct 15, 2024
@tetrapod00
Copy link
Contributor Author

Pushed a change which removes the note entirely.

@tetrapod00 tetrapod00 changed the title Remove discord reference in Submitting to Asset Library Remove note in Submitting to Asset Library Oct 16, 2024
@mhilbrunner mhilbrunner merged commit 26769a6 into godotengine:master Oct 16, 2024
1 check passed
@mhilbrunner
Copy link
Member

Thank you! Merged.

@tetrapod00 tetrapod00 deleted the remove-discord-ref branch October 16, 2024 03:04
@mhilbrunner
Copy link
Member

Cherrypicked to 4.3 in #10346.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:community Issues and PRs related to the Community section of the documentation enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants