Fix unreachable pages under 3D Particles by using fake headers #10110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Converts all headers in tutorials\3d\particles\index.rst to fake rubric headers. Note that in this case we can't have any real subheaders on the page due to the order of the sections.
This was referenced Oct 18, 2024
|
If #10111 is approved, this will need changes. |
mhilbrunner
approved these changes
Oct 30, 2024
mhilbrunner
added
bug
area:manual
|
Thanks! |
|
Cherrypicked to 4.3 in #10346. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #8792.
Applies a similar fix as #9989. Converts all headers in
tutorials\3d\particles\index.rstto fake rubric headers. Note that in this case we can't have any real subheaders on the page at all, due to the order of the sections. If the page was structured like the following, thetoctreewould be counted as a subsection ofIntroductionand the pages would not appear in the sidebar.