Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mention callback argument count in The JavaScript bridge singleton #10162

Merged
merged 1 commit into from
Oct 29, 2024
Merged

Mention callback argument count in The JavaScript bridge singleton #10162

merged 1 commit into from
Oct 29, 2024

Conversation

Calinou
Copy link
Member

@Calinou Calinou commented Oct 29, 2024

@Calinou Calinou added enhancement area:manual Issues and PRs related to the Manual/Tutorials section of the documentation topic:porting platform:web cherrypick:4.3 labels Oct 29, 2024
@mhilbrunner mhilbrunner merged commit eb01c7c into godotengine:master Oct 29, 2024
1 check passed
@mhilbrunner
Copy link
Member

Thank you!

@Calinou Calinou deleted the javascript-bridge-callback-argument-count branch October 29, 2024 16:24
@mhilbrunner
Copy link
Member

Cherrypicked to 4.3 in #10346.

@Faless
Copy link
Contributor

Faless commented Dec 30, 2024

I missed this.

This is wrong.

Callbacks always get one argument, which is the JS arguments array. See the implementation for reference.

That should probably also be mentioned in the JavaScriptBridge.create_callback doc.

@Faless Faless mentioned this pull request Dec 30, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhilbrunner mhilbrunner mhilbrunner approved these changes

Assignees
No one assigned
Labels
area:manual Issues and PRs related to the Manual/Tutorials section of the documentation enhancement platform:web topic:porting
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Calinou @mhilbrunner @Faless