Improve display of rubric fake headers with :heading-level: option
#10187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tetrapod00
changed the title
:heading-level: option
|
This can be rebased now, with #10158 merged :) |
tetrapod00
force-pushed
the
rubric-headers
branch
from
8e37c07 to
2f634c7
Compare
|
Built this locally and checked the pages. They all seem to render fine. Now the rubric headers display as headers, they use actual
|
mhilbrunner
approved these changes
Nov 3, 2024
|
Thank you! 🙏 |
|
Cherrypicked to 4.3 in #10346. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supercedes #10111.
Depends on #10158. The minimum Sphinx version for the :heading-level: option is 7.4.1. (The CI will fail until it is updated to Sphinx 8)
In #9989 and followup PRs, real semantic headers were replaced by fake headers using the
.. rubric::directive. This PR allows those fake headers to look like real headers, using the sameh2andh3styles.