-
-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Using Fonts page for 4.0 #6373
Conversation
e4fb1ec
to
568ad1c
Compare
568ad1c
to
5e0a8a0
Compare
5e0a8a0
to
ffda1e7
Compare
ffda1e7
to
4c70397
Compare
4c70397
to
0761b3a
Compare
0761b3a
to
c1340dd
Compare
the "Using custom text" approach described below. | ||
|
||
After adding translations to the Project Settings, use the | ||
**Glyphs from the Translations** tab to check translations by double-clicking them, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've noticed that you need to double-click translations to add them, rather than single-clicking them. This doesn't seem logical to me, since there is no action that could otherwise be done by single-clicking. cc @bruvzg
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two minor issues, but other than those this PR looks great!
c1340dd
to
592b777
Compare
I improved the section on specifying character ranges using hexadecimal numbers or characters between single quotes: godot-docs/tutorials/ui/gui_using_fonts.rst Lines 95 to 103 in 592b777
Also, I've tested non-square bitmap fonts and can confirm they work, so I removed the line about the requirement for them to be square. |
Marked as draft as the section on emoji support needs to be completed. I'm waiting for godotengine/godot#64530 to be merged here, as it will ensure emoji support works better out of the box.Edit: godotengine/godot#64530 is now merged, so this PR is ready for review. godotengine/godot#68995 will further improve usability, but I can open another PR to update the documentation as a follow-up.