Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Using fonts documentation for 4.0.beta17 #6748

Merged
merged 1 commit into from
Feb 8, 2023

Conversation

Calinou
Copy link
Member

@Calinou Calinou commented Feb 8, 2023

This updates documentation to match changes from godotengine/godot#68470.


  • Mention subpixel positioning should be disabled for fonts with a pixel art appearance.
  • Update bitmap font import dock image and document image/character margin.
  • Fixed character range example to match the font image (it previously had to be reduced by 1 due to an off-by-one error in the importer code).

This closes godotengine/godot#70327.

@bruvzg I've noticed that I need to set the character range to 0-126 and not 0-127 to get the example font to import correctly. Otherwise, I get an "out of range" error (the font has exactly 128 glyphs - 16 columns and 8 rows). Is that expected?

Edit: I updated the documentation according to #6748 (comment).

@Calinou Calinou added enhancement area:manual Issues and PRs related to the Manual/Tutorials section of the documentation labels Feb 8, 2023
@bruvzg
Copy link
Member

bruvzg commented Feb 8, 2023

I've noticed that I need to set the character range to 0-126 and not 0-127 to get the example fontto import correctly. Otherwise, I get an "out of range" error (the font has exactly 128 glyphs - 16 columns and 8 rows). Is that expected?

Bug (godotengine/godot#72887).

- Mention subpixel positioning should be disabled for fonts with a pixel art
  appearance.
- Update bitmap font import dock image and document image/character margin.
- Fixed character range example to match the font image (it previously
  had to be reduced by 1 due to an off-by-one error in the importer code).
@Calinou Calinou force-pushed the update-using-fonts branch from bab25cb to f8a612c Compare February 8, 2023 13:45
@akien-mga akien-mga merged commit 42523a3 into godotengine:master Feb 8, 2023
@akien-mga
Copy link
Member

Thanks!

@Calinou Calinou deleted the update-using-fonts branch February 8, 2023 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:manual Issues and PRs related to the Manual/Tutorials section of the documentation enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Button font is rendered incorrectly when using pixel art TTF font
4 participants