Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Image Font Importer] Hide unused font size, add image and character margins. #68470

Merged
merged 1 commit into from
Nov 14, 2022
Merged

[Image Font Importer] Hide unused font size, add image and character margins. #68470

merged 1 commit into from
Nov 14, 2022

Conversation

bruvzg
Copy link
Member

@bruvzg bruvzg commented Nov 10, 2022

  • Removes unused font size option(actual glyph height, calculated for rows/image height, is used as font size instead).
  • Adds image margin option (part of the source image to ignore).
  • Adds character margin option (part of the character to ignore).

Screenshot 2022-11-10 at 08 40 59
(red part removed by image margin, green grid remove by character margin)

@bruvzg bruvzg added this to the 4.x milestone Nov 10, 2022
@bruvzg bruvzg requested a review from a team as a code owner November 10, 2022 06:51
@akien-mga akien-mga modified the milestones: 4.x, 4.0 Nov 14, 2022
@akien-mga akien-mga merged commit 19f21e2 into godotengine:master Nov 14, 2022
@bruvzg bruvzg deleted the img_fnt_imp branch November 14, 2022 10:14
@akien-mga
Copy link
Member

Thanks!

@Calinou Calinou mentioned this pull request Jun 20, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akien-mga akien-mga akien-mga approved these changes

Assignees
No one assigned
Labels
enhancement topic:editor topic:import
Projects
None yet
Milestone
4.0
Development

Successfully merging this pull request may close these issues.
2 participants
@bruvzg @akien-mga