Several improvements to "First 3D Game" tutorial #8460
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shane-smith
changed the title
Calinou
added
enhancement
area:getting started
Calinou
reviewed
Nov 16, 2023
Calinou
reviewed
Nov 16, 2023
Calinou
reviewed
Nov 16, 2023
Calinou
reviewed
Nov 16, 2023
|
Thanks for the feedback! I'll work on this and get back to you. |
|
I will squash this into a single commit (and rebase on the current master branch) and then it's ready for re-review. |
shane-smith
force-pushed
the
patch-first-3d-game
branch
from
9af0531
to
62cbcf1
Compare
|
It is ready for you now @Calinou - let me know if you have any further feedback 🙂 |
skyace65
approved these changes
Nov 29, 2023
There was a problem hiding this comment.
This looks good, I'd prefer to leave the "article outdated" warnings for now. There's still stuff on other pages that needs to be updated or fixed. but I'd be okay with merging this as is if others think it's fine.
I'll work on a PR to address the remaining issues once this one is merged.
|
I'll restore the warnings 👍 |
Fix Windows build command highlighting.
Update custom drawing in 2d tutorial to Godot4
Update D3D12 build instructions.
Update textureQueryLevels to mention it returns 1 when the texture is unassigned
Update OS to Time on pages containing OS.get_ticks_usec()
* Fixed typo in pr_workflow.rst
[Minor] Fix typo in `importing_images.rst` ("Rougness" should be "Roughness")
…a0d6e classref: Sync with current master branch (13a0d6e)
Update link to Rust GDExtension bindings
singletons_autoload.rst: add C# example similar to "Global Variable"
…minimum-requirements Update the Emscripten minimum requirements to 3.1.39
…ervers-typo Typo fix
Add info on finding script templates folder
Build offline version of stable branch
Update gui_using_fonts.rst
GDScript: Document `is not` operator
Remove duplicate information in autoload page
Update C# API in the code example of "Custom GUI controls"
Remove Godot 3 reference from profiler page
Clarify which track is being talked about
Clarify which scene to run in step by step
…990cd classref: Sync with current master branch (4e990cd)
Update compiling_for_linuxbsd.rst Added a description that compiling for RISC-V devices
This fixes the "Animation > Copy" issue mentioned in godotengine#6744 (see Step 09, around Line 264) The same issue as above was referenced in godotengine/godot#60848 and the fix was to use the solution by @riidom Also, a reference to a button icon has been changed from "A+" to "A>" per feedback on PR 8460
…godot-docs into patch-first-3d-game
|
Salvaged by #8955 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The tutorial has been marked as compatible with the latest version - I just ran through it and verified that each step can be completed in Godot 4.1.3 stable.
A few fixes have been made, and other sections clarified to help first-time users of Godot.
I have made no changes to images - only text.
Note that this also fixes the "Animation > Copy" issue mentioned in #6744