Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix export annotation being formatted as Godot 3. #8711

Merged
merged 1 commit into from
Jan 6, 2024

Conversation

IntangibleMatter
Copy link
Contributor

While browsing the docs, I noticed that there was a bit of code obviously misformatted for Godot 4. Fixed it, hopefully.

While browsing the docs, I noticed that there was a bit of code obviously misformatted for Godot 4. Fixed it, hopefully.
@skyace65 skyace65 added bug area:manual Issues and PRs related to the Manual/Tutorials section of the documentation cherrypick:4.2 labels Jan 6, 2024
@skyace65 skyace65 merged commit a98c352 into godotengine:master Jan 6, 2024
1 check passed
@skyace65
Copy link
Contributor

skyace65 commented Jan 6, 2024

Thanks! And congrats on your first merged PR!

@IntangibleMatter
Copy link
Contributor Author

Thanks! And I see this was cherry-picked for Godot 4.2, but I recommend backporting to 4.1 and 4.0, as this primarily affects new users, and I've seen new users be in the wrong version of the 4.x docs a few times. Just a thought!

mhilbrunner pushed a commit that referenced this pull request Jan 25, 2024
Fix export annotation being formatted as Godot 3.
@mhilbrunner
Copy link
Member

Cherry-picked to 4.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:manual Issues and PRs related to the Manual/Tutorials section of the documentation bug cherrypick:4.0 cherrypick:4.1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants