Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove incorrect "we won't use the index array" #8839

Merged
merged 1 commit into from
Feb 23, 2024

Conversation

timeeeee
Copy link
Contributor

This is a small correction. The "Using the ArrayMesh" tutorial says "In fact, we won't use the index array at all" for ArrayMesh.add_surface_from_arrays(), but the example code does actually use the index array.

This is also addressed in issue #6166.

Copy link
Contributor

@Mickeon Mickeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reasonable to me.

@timeeeee timeeeee closed this Feb 11, 2024
@timeeeee timeeeee reopened this Feb 11, 2024
@AThousandShips AThousandShips added enhancement area:manual Issues and PRs related to the Manual/Tutorials section of the documentation labels Feb 12, 2024
@skyace65 skyace65 merged commit 6a19c12 into godotengine:master Feb 23, 2024
2 checks passed
@skyace65
Copy link
Contributor

Thanks! And congrats on your first merged PR!

@timeeeee
Copy link
Contributor Author

Thanks! And congrats on your first merged PR!

Thank you all for for everything you do!

@mhilbrunner
Copy link
Member

Cherry-picked to 4.2 in #9647.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:manual Issues and PRs related to the Manual/Tutorials section of the documentation enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants