Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve clarity of 2d tutorial section #8959

Merged
merged 1 commit into from
Feb 15, 2024
Merged

Improve clarity of 2d tutorial section #8959

merged 1 commit into from
Feb 15, 2024

Conversation

jamesplease
Copy link
Contributor

This moves the note about the unit of time closer to where they are actually used.

@AThousandShips
Copy link
Member

Thank you for your contribution!

You should target master not 4.2, changes can then be cherry picked, see here.

If you need more information about the update process please see: here. If wanted I can fix the branch for you.

@AThousandShips AThousandShips added the needs work Needs additional work by the original author, someone else or in another repo. label Feb 14, 2024
@jamesplease jamesplease changed the base branch from 4.2 to master February 14, 2024 17:49
@jamesplease
Copy link
Contributor Author

My mistake! Sorry about that – it's my first time contributing 🙂 I've updated the PR to point to master. Let me know if there's anything else I need to update. And thank you!

@AThousandShips
Copy link
Member

Please see the instructions, you need to rebase your branch :)

@jamesplease
Copy link
Contributor Author

Second time's the charm? Thanks again for your patience.

@AThousandShips AThousandShips added enhancement area:getting started Issues and PRs related to the Getting Started section of the documentation and removed needs work Needs additional work by the original author, someone else or in another repo. labels Feb 14, 2024
@skyace65 skyace65 merged commit bc67ff2 into godotengine:master Feb 15, 2024
1 check passed
@skyace65
Copy link
Contributor

Thanks! And congrats on your first merged PR!

@jamesplease jamesplease deleted the patch-1 branch February 15, 2024 00:29
@jamesplease
Copy link
Contributor Author

I appreciate you both @AThousandShips @skyace65 ❤️

@mhilbrunner
Copy link
Member

Cherry-picked to 4.2 in #9647.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skyace65 skyace65 skyace65 approved these changes

Assignees
No one assigned
Labels
area:getting started Issues and PRs related to the Getting Started section of the documentation enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jamesplease @AThousandShips @skyace65 @mhilbrunner