-
-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Web] Expand "Interacting with Javascript" #8986
Conversation
4a3b560
to
b4bf3aa
Compare
b4bf3aa
to
2450c60
Compare
@TheYellowArchitect thanks for the review! Fixed :) |
2450c60
to
71956e4
Compare
@AThousandShips thanks! Fixed :) |
71956e4
to
95777b3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some suggestions below. In general, this tutorial uses a lot of code comments for explanations, which is problematic as they (currently) can't be translated, which admittedly is a fault of our tooling. Where possible, it would be good to move more explanations to the tutorial text.
Otherwise, this looks good to me and covers something frequently asked about :)
Document the new (preferred) interface. Add a small section about downloading files to the user device.
77e5d9f
to
712aa0c
Compare
I've applied the suggestions. As discussed in chat, I'd rather merge this and stop telling people to use Hopefully we can find someone to improve this in follow up PRs, since I won't have time to work more on this (I also have to port the Multiplayer Replication article). EDIT: Also, thanks for the in-depth review! :) |
Thank you! :) Merged. |
Cherry-picked to 4.2 in #9647. |
Document the new (preferred) interface.
Add a small section about downloading files to the user device.
Based on: https://godotengine.org/article/godot-web-progress-report-9/
Should be back-ported to 3.x/3.5 for which it needs changes to the code block about
to_utf8_buffer
/to_utf8
,create_callback
argument types, andFileAccess
/File
.