Update list of spatial shader render modes for Godot 4.3 #9691
+29
−18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Calinou
added
enhancement
area:manual
Calinou
commented
Aug 1, 2024
Comment on lines
+354
to
+357
| | out float **PREMUL_ALPHA_FACTOR** | Premultiplied alpha factor. Only effective if ``render_mode blend_premul_alpha;`` is used. | | ||
| | | This should be written to when using a *shaded* material with premultiplied alpha blending for | | ||
| | | interaction with lighting. This is not required for unshaded materials. | | ||
| +----------------------------------------+--------------------------------------------------------------------------------------------------+ |
There was a problem hiding this comment.
Any ideas of a concrete example? I've based this description on the existing class reference, but it's not really obvious how you're supposed to write to it in a typical shaded PBR material scenario.
Calinou
force-pushed
the
spatial-shader-update-render-modes
branch
from
a74c89d
to
cce46dc
Compare
This also improves the documentation for existing render modes.
Calinou
force-pushed
the
spatial-shader-update-render-modes
branch
from
cce46dc
to
6001307
Compare
tetrapod00
reviewed
Aug 14, 2024
| | out float **METALLIC** | Metallic (0..1). | | ||
| +----------------------------------------+--------------------------------------------------------------------------------------------------+ | ||
| | out float **SPECULAR** | Specular. Defaults to 0.5, best not to modify unless you want to change IOR. | | ||
| | out float **SPECULAR** | Specular (not physically accurate to change). Defaults to ``0.5``. ``0.0`` disables reflections. | | ||
| +----------------------------------------+--------------------------------------------------------------------------------------------------+ | ||
| | out float **ROUGHNESS** | Roughness (0..1). | | ||
| +----------------------------------------+--------------------------------------------------------------------------------------------------+ | ||
| | out float **RIM** | Rim (0..1). If used, Godot calculates rim lighting. | |
There was a problem hiding this comment.
Suggested change
| | out float **RIM** | Rim (0..1). If used, Godot calculates rim lighting. | | |
| | out float **RIM** | Rim (0..1). If used, Godot calculates rim lighting. Rim size depends on ``ROUGHNESS``. | |
Same wording as here. Rim light "not showing up" when the roughness is set to the default value of 1 is a common enough problem to document here IMO.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also improves the documentation for existing render modes.
specular_disabledrender mode in shaders does not make theSPECULARoutput zero godot#95102.unshadedrender mode for quad in Advanced post-processing #9690.