-
-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add C# examples to High-level Multiplayer documentation #9798
Add C# examples to High-level Multiplayer documentation #9798
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for contributing to the .NET documentation!
I made a few comments regarding consistency with the GDScript code and C# code-style. I have not tested that the code works, but as long as it's equivalent to the GDScript I assume it does. I have, however, tested whether it compiles successfully.
Hey @raulsntos thanks so much for the review 🥳, I did copy most of it from a working implementation of that lobby example I did in c# 😁 will add suggested changes |
98be324
to
2adce89
Compare
0248264
to
f9be250
Compare
4a5c796
to
5ffa23a
Compare
updated references to _playerInfo and access modifiers 👍🏻 |
860b922
to
d06391f
Compare
Co-authored-by: Raul Santos <raulsntos@gmail.com>
639ffdb
to
c4a17ab
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, thanks!
Thanks! |
Cherry-picked to 4.3 in #10038. |
Adds C# examples to High-level Multiplayer documentation