Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix shader language matrix row/col convention #9846

Merged
merged 1 commit into from
Oct 20, 2024
Merged

Fix shader language matrix row/col convention #9846

merged 1 commit into from
Oct 20, 2024

Conversation

Flarkk
Copy link
Contributor

@Flarkk Flarkk commented Aug 27, 2024 •
edited
Loading

Fixes #5805
Fixes #9616

@Flarkk Flarkk force-pushed the shader_matrix_convention branch 2 times, most recently from 7eabb92 to af23090 Compare August 27, 2024 14:34
@Flarkk Flarkk force-pushed the shader_matrix_convention branch from 67a2984 to 54f368c Compare August 27, 2024 14:44
@skyace65 skyace65 added bug area:manual Issues and PRs related to the Manual/Tutorials section of the documentation topic:shaders labels Aug 29, 2024
@AThousandShips AThousandShips requested review from a team August 30, 2024 14:39
Mickeon
Mickeon reviewed Sep 8, 2024
View reviewed changes
Copy link
Contributor

@Mickeon Mickeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to be factually correct and what I have come to know myself, but an additional look by one more shader-savvy person may be necessary.

@mhilbrunner mhilbrunner merged commit 7061a2a into godotengine:master Oct 20, 2024
1 check passed
@mhilbrunner
Copy link
Member

Merged. Thanks and congrats on your first merged contribution! Sorry this took a bit :)

@Flarkk Flarkk deleted the shader_matrix_convention branch October 20, 2024 11:25
@mhilbrunner
Copy link
Member

Cherrypicked to 4.3 in #10346.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mickeon Mickeon Mickeon left review comments

@clayjohn clayjohn clayjohn approved these changes

@mhilbrunner mhilbrunner mhilbrunner approved these changes

Assignees
No one assigned
Labels
area:manual Issues and PRs related to the Manual/Tutorials section of the documentation bug topic:shaders
Projects
None yet
Milestone
No milestone
5 participants
@Flarkk @mhilbrunner @clayjohn @Mickeon @skyace65