Update godot-cpp to the latest on the 4.1
branch
#246
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the godot-cpp used by this extension to the latest on godot-cpp's
4.1
branch.This will mean that the extension will only be compatible with Godot 4.1.4 or later due to the updates to the
extension_api.json
. However, if it was important than it still worked with Godot 4.1.0 to 4.1.3, then it should be possible to compile withscons custom_api_file=path/to/extension_api.json
where that JSON file is from Godot 4.1.0 - and we could even stash thatextension_api.json
in the repo? Anyway, just let me know if you'd like adjustments for that.However, updating to the newest godot-cpp that will work with Godot 4.1 will include a whole bunch of bug fixes that have been cherry-picked since then.
For example, PR godotengine/godot-cpp#1313 which fixes #239
As well as other various memory leaks, crashes, build-system improvements, etc.