Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update godot-cpp to the latest on the 4.1 branch #246

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dsnopek
Copy link

@dsnopek dsnopek commented Jul 10, 2024

This updates the godot-cpp used by this extension to the latest on godot-cpp's 4.1 branch.

This will mean that the extension will only be compatible with Godot 4.1.4 or later due to the updates to the extension_api.json. However, if it was important than it still worked with Godot 4.1.0 to 4.1.3, then it should be possible to compile with scons custom_api_file=path/to/extension_api.json where that JSON file is from Godot 4.1.0 - and we could even stash that extension_api.json in the repo? Anyway, just let me know if you'd like adjustments for that.

However, updating to the newest godot-cpp that will work with Godot 4.1 will include a whole bunch of bug fixes that have been cherry-picked since then.

For example, PR godotengine/godot-cpp#1313 which fixes #239

As well as other various memory leaks, crashes, build-system improvements, etc.

@dsnopek
Copy link
Author

dsnopek commented Jul 10, 2024

Hm, not sure why SCons is failing on the CI, it's working for me locally...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Editor crashes with running multiple GDExtension libraries
1 participant