Skip to content

Commit

Permalink
Merge pull request #79792 from Miguel0312/SceneTreeTooltips
Browse files Browse the repository at this point in the history
Correctly display tooltips for buttons in Tree when they overlap cell content
  • Loading branch information
akien-mga committed Sep 4, 2023
2 parents dd4fae6 + 8278a5f commit 92da5a7
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 10 deletions.
13 changes: 3 additions & 10 deletions scene/gui/tree.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -2411,6 +2411,7 @@ int Tree::draw_item(const Point2i &p_pos, const Point2 &p_draw_ofs, const Size2
if (rtl) {
button_ofs.x = get_size().width - button_ofs.x - button_texture->get_width();
}
p_item->cells.write[i].buttons.write[j].rect = Rect2i(button_ofs, button_size);
button_texture->draw(ci, button_ofs, p_item->cells[i].buttons[j].disabled ? Color(1, 1, 1, 0.5) : p_item->cells[i].buttons[j].color);
item_width_with_buttons -= button_size.width + theme_cache.button_margin;
}
Expand Down Expand Up @@ -5350,6 +5351,7 @@ String Tree::get_tooltip(const Point2 &p_pos) const {
return Control::get_tooltip(p_pos);
}

Point2 button_pos = pos;
if (h_scroll->is_visible_in_tree()) {
pos.x += h_scroll->get_value();
}
Expand All @@ -5362,22 +5364,13 @@ String Tree::get_tooltip(const Point2 &p_pos) const {

if (it) {
const TreeItem::Cell &c = it->cells[col];
int col_width = get_column_width(col);

for (int i = 0; i < col; i++) {
pos.x -= get_column_width(i);
}

for (int j = c.buttons.size() - 1; j >= 0; j--) {
Ref<Texture2D> b = c.buttons[j].texture;
Size2 size = b->get_size() + theme_cache.button_pressed->get_minimum_size();
if (pos.x > col_width - size.width) {
if (c.buttons[j].rect.has_point(button_pos)) {
String tooltip = c.buttons[j].tooltip;
if (!tooltip.is_empty()) {
return tooltip;
}
}
col_width -= size.width;
}
String ret;
if (it->get_tooltip_text(col) == "") {
Expand Down
1 change: 1 addition & 0 deletions scene/gui/tree.h
Original file line number Diff line number Diff line change
Expand Up @@ -108,6 +108,7 @@ class TreeItem : public Object {
Ref<Texture2D> texture;
Color color = Color(1, 1, 1, 1);
String tooltip;
Rect2i rect;
};

Vector<Button> buttons;
Expand Down

0 comments on commit 92da5a7

Please sign in to comment.