Correctly display tooltips for buttons in Tree when they overlap cell content (reverted)

[Miguel0312]

Closes #79629

I copied the 3.x behavior for the SceneTree: once the width becomes too small, the overflowing text of the node's name is hidden.

The way I found to do this is by creating a second column in the TreeItem and adding the buttons to this column to make sure that there is no overlap. I also set the clip property of the first column to false in order to hide the overflow

[YuriSizov]

That doesn't really solve the problem and also introduces an ugly visual bug. If buttons that overlap text don't show their tooltips and instead the text content's tooltip is shown, then we should make sure that the elements which are visually on top contribute to the tooltip ahead of the elements which are below.

See Tree::get_tooltip and check if it tests for buttons too late, instead.

[Miguel0312]

I found the bug. The get_tooltip function didn't take into account the fact that when we have an h_bar the button is not at the end of the TreeItem. I just had to take the offset between the size of the item and the size of the element being displayed. Now we have the following:

[YuriSizov]

Okay, so after looking through the logic and the suggested change I think that the solution should be to add position to the Button struct and cache it during the drawing step. Then use it here to determine if we are over the button or not. The logic for determining the exact placement of each button is rather complex and it's counter-productive to try and replicate it or approximate its values by some other means.

The change needs to happen in Tree::draw_item around the code that draws the button texture, as that's where we have the exact position and size. We can even cache entire Rect2, as the size can also be limited by other factors and not come from the texture itself. Then the check in the get_tooltip method can just try to see if this rect includes our position.

Edit: It may also help to simplify the code that checks for buttons being pressed.

[YuriSizov]

See above.

[Miguel0312]

I modified the implementation to use the cache as explained on the comment above. The result is the same as before (it also works for vertical-scrolling):

[YuriSizov]

Almost ready, but you've removed a bit too much. Make sure to test with multicolumn Trees.

I would also recommend rebasing against the current master, as your base commit is over a month old.

Edit: Oh, and please amend the commit message. The title of the PR is a good option.

[YuriSizov]

LGTM.

There are still some inconsistencies regarding buttons' position when we detect clicks, but it's a pre-existing issue that's unrelated to this. I'll take a look as a follow-up to this PR.

[akien-mga]

Thanks!