Fix user selection on top of bgcolor areas in a RichTextLabel
#100208
+7
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AThousandShips
added
bug
topic:gui
cherrypick:4.3
bruvzg
approved these changes
Dec 11, 2024
|
Thanks! Congratulations on your first merged contribution! 🎉 |
|
Thanks, feels awesome! I've reported a few bugs before but this is my first merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Fixes #100072.
It seems that when rendering a
RichTextLabelthe selected text is rendered second last before the text itself. This causes the error illustrated in #100072 where selecting text can sometimes be rendered below the background color.This fix moves the selection rendering to be after that, and the bug goes away as shown in this screenshot:
I can't think of a good reason to render the background color after the selection so I think this code is safe, but if someone more familiar with the
RichTextLabelwants to chime in I'd appreciate it. cc @bruvzg since they touched this code most recently.