[4.3] Cherry-picks for the 4.3 (4.3.1) branch - 1st gui bugs batch #944
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit 41a1a7f)
(cherry picked from commit b4efd27)
(cherry picked from commit 2f4f39c)
The color picker has a "legacy" fallback mode when `FEATURE_SCREEN_CAPTURE` is not supported by the current `DisplayServer`. It works by "freezing" the current view by making a huge `Popup` with a `TextureRect` inside covering the screen. Before this patch, said `TextureRect` could get cut off if its buffer was nominally bigger than the parent popup, such as when the `canvas_items` content scale mode is active. This is because the default TextureRect scaling logic only allows expanding the texture up. `EXPAND_IGNORE_SIZE` fixes that by allowing the texture to logically "shrink", filling the whole screen independently of the actual buffer size. Special thanks to Federico Fausto Santoro for helping with the diagnosis :D Co-Authored-By: Federico Fausto Santoro <fedyfausto@hotmail.com> (cherry picked from commit ef48c4d)
(cherry picked from commit ff6eea5)
(cherry picked from commit 0f98b32)
(cherry picked from commit 2e57089)
(cherry picked from commit e371587)
(cherry picked from commit c36f466)
… arrow steps (cherry picked from commit afeecad)
(cherry picked from commit 93ae8d8)
(cherry picked from commit a328952)
(cherry picked from commit 9f6c88d)
(cherry picked from commit 60fa3ec)
(cherry picked from commit 14dd595)
(cherry picked from commit 3e30dd7)
(cherry picked from commit 1764269)
(cherry picked from commit b131476)
Replace two while loops with fposmodp. Document radial_initial_angle wrapping. Add testcases for set_radial_initial_angle() (cherry picked from commit d692b7b)
(cherry picked from commit f6751d8)
(cherry picked from commit 15bd2a9)
(cherry picked from commit 1e749f6)
(cherry picked from commit b905014)
…size (cherry picked from commit 94a7dfe)
(cherry picked from commit 1f75151)
(cherry picked from commit 3e333df)
SkogiB
approved these changes
Jan 23, 2025
tindrew
approved these changes
Jan 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GUI Bug PRs:
DRAW_STEP_TEXTgodotengine/godot#96247_drawgodotengine/godot#97328ETRmacros inColorPickergodotengine/godot#97398ui_cancelaction godotengine/godot#97660PopupMenu.id_focusedsignal using index as ID godotengine/godot#97890MenuBarscene after child renamed in editor godotengine/godot#97977LineEdit,TextEditandCodeEditvirtual keyboard popup on mobile godotengine/godot#98012CanvasLayer. godotengine/godot#98032Treeis rotated godotengine/godot#98299FileDialog's file list godotengine/godot#98720TextureProgressBar.set_radial_initial_angle()by removing loops godotengine/godot#98816TextureProgressBarradial center cross only when editing the scene godotengine/godot#99685bgcolorareas in aRichTextLabelgodotengine/godot#100208RichTextLabelbbcode rainbow play reversed and paused godotengine/godot#100494has_fontandhas_font_sizealways return true godotengine/godot#101066get_visible_line_countin RichTextLabel godotengine/godot#101205Extra PRs:
LineEditfocus loss when text is submitted or rejected and allow selecting without editing with arrow keys. godotengine/godot#87674