Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix button click detection when Tree is rotated #98299

Merged
merged 1 commit into from
Oct 21, 2024

Conversation

timothyqiu
Copy link
Member

@timothyqiu timothyqiu commented Oct 18, 2024

Transform coordinate properly instead of trying to calculate that manually.

MRP: test-4.zip

Bugsquad edit:

@timothyqiu timothyqiu added bug topic:gui cherrypick:4.3 Considered for cherry-picking into a future 4.3.x release labels Oct 18, 2024
@timothyqiu timothyqiu added this to the 4.4 milestone Oct 18, 2024
@timothyqiu timothyqiu requested a review from a team as a code owner October 18, 2024 14:48
Copy link
Contributor

@Sauermann Sauermann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Implementation and code style looks correct.
I have tested the PR rebased on 58a7f9b and it fixes the bug.

@thygrrr
Copy link
Contributor

thygrrr commented Oct 19, 2024

LGTM! An important fix, I had wondered what was wrong with rotated controls / trees.

@Repiteo Repiteo merged commit b3bcb2d into godotengine:master Oct 21, 2024
20 checks passed
@Repiteo
Copy link
Contributor

Repiteo commented Oct 21, 2024

Thanks!

@akien-mga
Copy link
Member

Cherry-picked for 4.3.1.

@akien-mga akien-mga removed the cherrypick:4.3 Considered for cherry-picking into a future 4.3.x release label Jan 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TreeItem Button willl not press on a scaled Tree
5 participants