Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable auto translation of FileDialog's file list #98720

Merged
merged 1 commit into from
Nov 10, 2024
Merged

Disable auto translation of FileDialog's file list #98720

merged 1 commit into from
Nov 10, 2024

Conversation

timothyqiu
Copy link
Member

Test project: test-4.zip

@timothyqiu timothyqiu added bug topic:gui cherrypick:4.3 Considered for cherry-picking into a future 4.3.x release labels Nov 1, 2024
@timothyqiu timothyqiu added this to the 4.4 milestone Nov 1, 2024
@timothyqiu timothyqiu requested a review from a team as a code owner November 1, 2024 04:43
bruvzg
bruvzg approved these changes Nov 1, 2024
View reviewed changes
Copy link
Member

@bruvzg bruvzg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seem to work fine. For the reference, editor dialog use ItemList instead of Tree and already have auto translation disabled.

@Repiteo Repiteo merged commit 792671f into godotengine:master Nov 10, 2024
20 checks passed
@Repiteo
Copy link
Contributor

Repiteo commented Nov 10, 2024

Thanks!

@timothyqiu timothyqiu deleted the file-dialog-atm branch November 11, 2024 01:04
@Spartan322 Spartan322 mentioned this pull request Jan 22, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bruvzg bruvzg bruvzg approved these changes

Assignees
No one assigned
Labels
bug cherrypick:4.3 Considered for cherry-picking into a future 4.3.x release topic:gui
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.
3 participants
@timothyqiu @Repiteo @bruvzg