Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix button text autowrap overflow when inside a container #97389

Merged
merged 1 commit into from
Sep 26, 2024

Conversation

timothyqiu
Copy link
Member

Fixes #97355

The width of Paragraph is only set when drawing. When autowrap is enabled, a change in paragraph width changes the minimum height.

Also removed two unused header includes.

@timothyqiu timothyqiu added this to the 4.4 milestone Sep 24, 2024
@timothyqiu timothyqiu requested a review from a team as a code owner September 24, 2024 01:59
@timothyqiu timothyqiu requested a review from bruvzg September 24, 2024 01:59
@akien-mga akien-mga merged commit 775edd5 into godotengine:master Sep 26, 2024
19 checks passed
@akien-mga
Copy link
Member

Thanks!

@timothyqiu timothyqiu deleted the button-autowrap-min-size branch September 26, 2024 22:57
ahxgamma referenced this pull request in ahxgamma/redot-engine Oct 1, 2024
…-size"

This reverts commit 775edd5, reversing
changes made to 344ce2b.
@akien-mga akien-mga added the cherrypick:4.3 Considered for cherry-picking into a future 4.3.x release label Dec 9, 2024
@akien-mga
Copy link
Member

Cherry-picked for 4.3.1.

@akien-mga akien-mga removed the cherrypick:4.3 Considered for cherry-picking into a future 4.3.x release label Jan 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Control] Button Text Overflow when Assigning by Script
4 participants