Major update for visual shader system

[Chaosus]

I know you guys like visual shaders so I've decided to attempt to improve it.
And with the proposed changes it will be possible to create much more complex effects.

1. Redesigned Add menu

• Now its a dialog with tree instead menu

• Have categories and subcategories

• Exposed all math functions in easy manner with description !

• Support context search

• Have a drag & drop capacity

• All of items in the tree are sorted alphabetically

• Can be resized for best looking, and save its transform for next time user called it

• Have options to collapse and expand all items

• Called by right-click as usual

• Will create node at last cursor position instead always center

• The Add nodes... button remains its functionality - dialog has been placed on the top left corner and created node pushed to center as it was

2. New functions.

• Several new API functions from glsl has been pushed to visual shaders.

• I also exposed all scalar functions to Vector.

• Almost all GLSL functions now be available for developers !

• Exposed Input's for easy access - category Input will contains all the inputs for different types of shader modes. Dont worry the parameters which are exist in all three shader modes(Fragment, Light or Vertex) will be under "All" sub-dir..

Clicking on each one just created Input node with specified parameter

New API :

• ColorFunc - Contains Grayscale and Sepia effects

• BooleanUniform and BooleanConstant
  These nodes can be translated to scalar or vector and can be useful to achive some effects based on boolean logic.

• TransformFunc - Contains Inverse and Transpose

• ScalarDerivative and VectorDerivative - Contains Ddx(dFdx), Ddy(dFdy), Sum(fwidth)

New Builtins :

• ACosH
• ASinH
• ATanH
• Clamp
• Distance
• Exp2
• Log2
• SmoothStep
• Step
• FaceForward
• Radians
• Reflect
• Refract
• RoundEven
• Degrees
• Determinant
• Trunc
• InverseSqrt
• Reciprocal for scalars
• OuterProduct
• matrixCompMult has been added to TransformMult

Exposed to VectorFunc :

• Abs
• ACos
• ACosH
• ASin
• ASinH
• ATan
• ATanH
• Ceil
• Cos
• CosH
• Degrees
• Exp
• Exp2
• Floor
• Frac
• InverseSqrt
• Log
• Log2
• Radians
• Round
• RoundEven
• Sign
• Sin
• SinH
• Sqrt
• Tan
• TanH
• Trunc

Separate classes which has been added into core :

• VisualShaderNodeBooleanConstant
• VisualShaderNodeBooleanUniform
• VisualShaderNodeColorFunc
• VisualShaderNodeTransformFunc
• VisualShaderNodeDeterminant
• VisualShaderNodeScalarDerivativeFunc
• VisualShaderNodeVectorDerivativeFunc
• VisualShaderNodeScalarClamp
• VisualShaderNodeVectorClamp
• VisualShaderNodeFaceForward
• VisualShaderNodeOuterProduct
• VisualShaderNodeVectorScalarStep
• VisualShaderNodeScalarSmoothStep
• VisualShaderNodeVectorSmoothStep
• VisualShaderNodeVectorScalarSmoothStep
• VisualShaderNodeVectorDistance
• VisualShaderNodeVectorRefract

Notes :

• Majority of new functions reused standart classes such as ScalarFunc or VectorFunc.

• So for example if you click on Cos under scalar section - it will create a ScalarFunc with Cos parameter

• I tried to achive backward compatibility - all new functions added above existed

• I opened for any acceptable critic and will improve this PR to end (merge) :) Please suggest your fixes or ideas.

• Where is a demo ? - https://youtu.be/wZRL2UpIDGo

Fixes :

• Fix VisualShader problem with UI #26230
• Fix Visual Shader Editor: right click menu gets cropped #25286
• Fix Missing feature in ShaderGraph: boolean uniform. #4362

[Chaosus]

So if you clicked on Node(by mouse) you just want to immediate focus on Search ? Currently focus on search does not allows you to press Enter to add node - it just filter the entire list for the comparsion - and after that you should choose the required one - after that there are 3 ways for add a node 1) Create button, 2) Hit Enter 3) Double mouse Click

[reduz]

This looks seriously amazing. I would also make the type icons remain there as default, no need for a toggle.

[Chaosus]

Great!

I would also make the type icons remain there as default, no need for a toggle.

Will fix it tomorrow..

[cbscribe]

There's currently a shader docs PR at godotengine/godot-docs/pull/2323 but it doesn't include any visual shader content (yet). Merging this would be a great time to add one. It's going to need a lot of screenshots, though, so I'd recommend waiting until it's merged in case of any last-minute changes.

[Chaosus]

@cbscribe Yes, of course, will wait if its needed

Can you check the shader nodes descriptions on editor/plugins/visual_shader_editor_plugin.cpp - majority of them has been taken from official OpenGL site however I changed them a bit..

Also, should I need to add xml docs for new classes (there are plenty of them) or they are generated automatically or something ?

[Chaosus]

I've added drag&drop - I found it is very useful method to add nodes to the graph

The only downside is (currently) you cannot interact with added nodes without closing dialog due to PopupDialog limitation(please correct me if im wrong), however you can delete them without closing dialog by using CTRL+Z(undo)

[groud]

@Chaosus couldn't you simply hide or disable the "Fragment" category when in vertex mode (and the other way around), instead of displaying an error message when you drag a wrong node ?

[Chaosus]

@groud yeah, good point, will fix it soon..

[Chaosus]

Ok, now Vertex/Fragment/Light in Input will show only in associated mode, also "Special" will not show in Vertex mode cuz its currently have only Derivative functions which are not supported by vertex anyways

[lentsius-bark]

Im back after a few weeks and mate, you're even more of a legend! My jaw dropped so hard my neighbours form three floors down had to bring it to me.

[akien-mga]

Thanks a ton!

[lentsius-bark]

It got merged in! Wow!

[ZX-WT]

This looks amazing :) I want to cry. I just have a brief look so I don't know whether some improvements are already included. Would you like to have a look at some github issues related to the visual shader system. Here's one of them for example :#21662

[Chaosus]

Well, I can look at them and solve, from time to time ^^

[spyres]

This is great stuff, but I wonder if anyone will look into the usability updates suggested here:

https://www.youtube.com/watch?v=vCIqblA2-dA

[clayjohn]

@spyres Thanks for your interest, but this PR is closed.

If you would like to suggest enhancements please open an issue laying out what you would like to see changed in text. Posting a video is not helpful for other contributors.

Please also note that the video you provided was made before this PR was merged and does not reflect the current state of the visual shader system.