Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add PROPERTY_USAGE_ALWAYS_SHARE_ON_DUPLICATE flag #41923

Closed
wants to merge 1 commit into from
Closed

Add PROPERTY_USAGE_ALWAYS_SHARE_ON_DUPLICATE flag #41923

wants to merge 1 commit into from

Conversation

jkb0o
Copy link
Contributor

@jkb0o jkb0o commented Sep 9, 2020

This adds PROPERTY_USAGE_ALWAYS_SHARE_ON_DUPLICATE flag. With this PR, Resource.duplicate will not duplicate Object.script property. Fixes #33079.

@jkb0o jkb0o changed the title [funexpected] add PROPERTY_USAGE_ALWAYS_SHARE_ON_DUPLICATE flag Add PROPERTY_USAGE_ALWAYS_SHARE_ON_DUPLICATE flag Sep 9, 2020
@jkb0o jkb0o mentioned this pull request Sep 9, 2020
Open
@akien-mga
Copy link
Member

Please avoid including [funexpected] in the commit title, it's not relevant to what the commit does.

If you want to acknowledge your company as author, it's OK to do it in the commit description though, e.g.:

Add PROPERTY_USAGE_ALWAYS_SHARE_ON_DUPLICATE flag

Fixes #33079.
Contributed by funexpected.

@jkb0o jkb0o force-pushed the always_share_on_duplicate branch 4 times, most recently from 3161fe8 to ffd7e5b Compare September 9, 2020 19:28
@Calinou Calinou added this to the 4.0 milestone Sep 9, 2020
@Mickeon Mickeon mentioned this pull request Sep 14, 2022
Closed
@mhilbrunner mhilbrunner mentioned this pull request Nov 1, 2022
Closed
mhilbrunner
mhilbrunner approved these changes Nov 1, 2022
View reviewed changes
Copy link
Member

@mhilbrunner mhilbrunner left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved in today's PR meeting including reduz. Needs to be rebased/salvaged.

@aaronfranke aaronfranke mentioned this pull request Jan 10, 2023
Merged
@akien-mga
Copy link
Member

Superseded by #71142.

@akien-mga akien-mga closed this Jan 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhilbrunner mhilbrunner mhilbrunner approved these changes

Assignees
No one assigned
Labels
archived bug topic:core
Projects
None yet
Milestone
4.0
Development

Successfully merging this pull request may close these issues.

Calling duplicate(true) on custom Resource returns empty Resource.
4 participants
@jkb0o @akien-mga @mhilbrunner @Calinou