[3.x] Add PROPERTY_USAGE_ALWAYS_SHARE_ON_DUPLICATE flag #41924
+3
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkb0o
force-pushed
the
always_share_on_duplicate_3.2
branch
4 times, most recently
from
fd7243a to
0ee4142
Compare
bruvzg
reviewed
Sep 9, 2020
core/object.h
Outdated
| PROPERTY_USAGE_NODE_PATH_FROM_SCENE_ROOT = 1 << 23, | ||
| PROPERTY_USAGE_RESOURCE_NOT_PERSISTENT = 1 << 24, | ||
| PROPERTY_USAGE_KEYING_INCREMENTS = 1 << 25, // Used in inspector to increment property when keyed in animation player | ||
| PROPERTY_USAGE_ALWAYS_SHARE_ON_DUPLICATE = 1 << 22, // If the object is duplicated this property will never be duplicated |
There was a problem hiding this comment.
For 3.2 it probably should be added to the end of the enum, to avoid breaking compatibility with existing GDNative libraries.
And it should be added to the NativeScript enum in the https://github.com/godotengine/godot/blob/master/modules/gdnative/include/nativescript/godot_nativescript.h#L87 (relevant for both this and #41923).
There was a problem hiding this comment.
There is a lot of missing enums in NativeScript (PROPERTY_USAGE_SCRIPT_DEFAULT_VALUE and others are missed). I guess all of them should be added in a separate commit.
Contributed by Funexpected.
jkb0o
force-pushed
the
always_share_on_duplicate_3.2
branch
from
0ee4142 to
a6c2880
Compare
akien-mga
changed the title
akien-mga
force-pushed
the
3.x
branch
2 times, most recently
from
71cb8d3 to
c58391c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds
PROPERTY_USAGE_ALWAYS_SHARE_ON_DUPLICATEflag for 3.2 branch (master #41923). With this PR,Resource.duplicatewill not duplicateObject.scriptproperty. Fixes #33079.