Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add filled, border_width, editor_only properties to ColorRect #42931

Closed
wants to merge 1 commit into from
Closed

Add filled, border_width, editor_only properties to ColorRect #42931

wants to merge 1 commit into from

Conversation

Xrayez
Copy link
Contributor

@Xrayez Xrayez commented Oct 20, 2020

Closes godotengine/godot-proposals#1687.

godot_color_rect_ref

In effect, this merges the functionality behind existing ReferenceRect into ColorRect. This way, ReferenceRect can be easily replicated via a simple script extending ColorRect:

@tool
class_name EditorRect extends ColorRect

func _init():
	color = Color.red
	filled = false
	editor_only = true

In theory, ReferenceRect can be removed from 4.0 because of that, but I have no strong opinion about this. If someone wants to remove ReferenceRect class, then I'll leave this up to others.

Note that the antialiased parameter is not present in 4.0, only in 3.2.

See also #42906 and #42907.

Test project:
color_rect.zip

In effect, this merges the functionality behind existing `ReferenceRect`
into `ColorRect`. This way, `ReferenceRect` can be easily replicated via
a simple script extending `ColorRect`:

```gdscript
@tool
class_name RefRect extends ColorRect

func _init():
	color = Color.red
	filled = false
	editor_only = true
```
@Xrayez Xrayez requested a review from a team as a code owner October 20, 2020 10:42
@Calinou Calinou added this to the 4.0 milestone Oct 20, 2020
@Xrayez Xrayez closed this Jun 25, 2021
@Xrayez Xrayez reopened this Dec 24, 2021
@Calinou Calinou removed the archived label Dec 24, 2021
@akien-mga
Copy link
Member

Closing as this contributor can no longer update this further.

@Zireael07
Copy link
Contributor

Worth picking up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Expose filled, width and antialiased properties in the ColorRect class
5 participants