Add filled, border_width, editor_only properties to ColorRect
#65549
Conversation
Ports over the properties of ReferenceRect to ColorRect itself. Also adds documentation.
Mickeon
force-pushed
the
salvage-color-rect-upgrade
branch
from
41164ba
to
19506f5
Compare
|
This might be not good place for such comments but it might be nice to also have border color? It would be possible to do color fill with border with different color. For example black box with red border. |
|
Having both fill and border color? That's not necessarily a bad idea, but by that point, StyleBoxFlat exists too for the same purpose, and has more features, too... I suppose it's at least worth considering, if this and #65559 are approved. |
| } break; | ||
| } | ||
| } | ||
|
|
||
| void ColorRect::_validate_property(PropertyInfo &property) const { |
|
We discussed this in a PR review meeting and decided to keep the current set of nodes simple:
Merging ReferenceRect features into ColorRect and removing ReferenceRect as suggested here would also be a viable option, but it also means that ColorRect gets even more overlap with StyleBoxFlat features and users might well ask for more features like rounded corners, etc., so we end up duplicating logic which is already supported in StyleBoxFlat. @Calinou suggested opening a proposal to allow converting a ColorRect to a Panel + StyleBoxFlat with the chosen color, which can be a base for more advanced use cases. |
|
Not the place for discussion, but for the same goals of Calinou's proposed solution, I feel like it would also be a good idea to make these types of Resources easier to set up and manage, like, in a way, ColorRect already is, simple as it is. No concrete proposed solution, just an afterthought. |
Salvages #42931.
Closes godotengine/godot-proposals#1687.
Ports over the properties of ReferenceRect to ColorRect itself.
This also renders ReferenceRect impressively redundant, but... It'd be very last minute to... ✂️ ✂️ ✂️ #65559