-
-
Notifications
You must be signed in to change notification settings - Fork 21.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes to recent Vulkan errors #44286
Conversation
@@ -14,7 +14,7 @@ layout(local_size_x = OCT_RES, local_size_y = OCT_RES, local_size_z = 1) in; | |||
layout(rgba16f, set = 0, binding = 1) uniform restrict image2DArray irradiance_texture; | |||
layout(rg16f, set = 0, binding = 2) uniform restrict image2DArray depth_texture; | |||
|
|||
ayout(rgba32ui, set = 0, binding = 3) uniform restrict uimage2DArray irradiance_history_texture; | |||
layout(rgba32ui, set = 0, binding = 3) uniform restrict uimage2DArray irradiance_history_texture; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not really a bug, this entire file is never used
@@ -2578,7 +2578,7 @@ RID RendererSceneRenderForward::_setup_render_pass_uniform_set(RID p_render_buff | |||
RD::Uniform u; | |||
u.binding = 12; | |||
u.uniform_type = RD::UNIFORM_TYPE_UNIFORM_BUFFER; | |||
u.ids.push_back(rb ? render_buffers_get_default_gi_probe_buffer() : render_buffers_get_gi_probe_buffer(p_render_buffers)); | |||
u.ids.push_back(rb ? render_buffers_get_gi_probe_buffer(p_render_buffers) : render_buffers_get_default_gi_probe_buffer()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixes bug when errors are spammed when using shadows (probably arises in other ways too)
@@ -2500,7 +2500,7 @@ RID RendererSceneRenderForward::_setup_render_pass_uniform_set(RID p_render_buff | |||
RD::Uniform u; | |||
u.binding = 4; | |||
u.uniform_type = RD::UNIFORM_TYPE_TEXTURE; | |||
RID texture = false && rb && rb->depth.is_valid() ? rb->depth : storage->texture_rd_get_default(RendererStorageRD::DEFAULT_RD_TEXTURE_WHITE); | |||
RID texture = rb && rb->depth.is_valid() ? rb->depth : storage->texture_rd_get_default(RendererStorageRD::DEFAULT_RD_TEXTURE_WHITE); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixes a typo
Thanks! |
Fixes some bugs introduced by #44175
Looks like SDFGI is still very broken. I explored it for a bit, but it was not obvious.