[3.2] Reduce lightmaps file size. #46054
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Calinou
previously requested changes
Feb 15, 2021
akien-mga
reviewed
Feb 15, 2021
Comment on lines
+111
to
+112
| if env["platform"] == "windows" and not env.msvc: | ||
| env_thirdparty.Append(CPPFLAGS=["-mstackrealign"]) |
|
On a related note, you may be interested in this if you haven't seen it: I did have a little try at getting it to work but not much joy. |
JFonS
force-pushed
the
cpu_lightmapper_disk
branch
from
599fab5 to
7932f3c
Compare
|
@lawnjelly Looks interesting indeed, but seems a bit too involved to get working... especially in 3.2. I updated the PR according to the feedback. I also enabled sRGB usage for low dynamic range textures, which significantly reduces banding. |
akien-mga
reviewed
Feb 16, 2021
Added BakedLightmap.use_hdr and BakedLightmap.use_color properties that can reduce the flie size of lightmap texture at the expense of quality. Changed the denoiser to work in a single buffer, reducing RAM usage. Also added the `-mstackrealign` flag in the denoiser compilation for MinGW builds. This flag helped fix a bug in Embree, so I want to see if it will help fix GH godotengine#45296.
JFonS
force-pushed
the
cpu_lightmapper_disk
branch
from
7932f3c to
56bf256
Compare
akien-mga
approved these changes
Feb 16, 2021
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A couple of commits that should help reduce the lightmap's file size:
Backport EXR compression support from master: this alone already makes a big difference, with EXR files being about 1/3 in size compared to their uncompressed equivalent.
Added options to reduce file size even further:
These two options can be used independently or can be combined to get the smallest texture file size possible.
I changed the denoiser to work in a single buffer, reducing RAM usage, and also added the
-mstackrealignflag in the denoiser compilation for MinGW builds. This flag helped fix a bug in Embree, so I want to see if it will also help with #45296.