Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the AudioStreamPlayer(2D/3D) class descriptions #48489

Merged
merged 1 commit into from
May 5, 2021

Conversation

Calinou
Copy link
Member

@Calinou Calinou commented May 5, 2021

This closes #48387.

@Calinou Calinou requested a review from a team as a code owner May 5, 2021 18:39
@Calinou Calinou force-pushed the doc-audiostreamplayer branch from 8dac990 to b90adec Compare May 5, 2021 18:39
@Calinou Calinou added cherrypick:3.3 cherrypick:3.x Considered for cherry-picking into a future 3.x release documentation enhancement labels May 5, 2021
@Calinou Calinou added this to the 4.0 milestone May 5, 2021
@akien-mga akien-mga merged commit 758bccf into godotengine:master May 5, 2021
@akien-mga
Copy link
Member

Thanks!

@akien-mga
Copy link
Member

Cherry-picked for 3.4.

@akien-mga akien-mga removed the cherrypick:3.x Considered for cherry-picking into a future 3.x release label May 9, 2021
@akien-mga
Copy link
Member

Cherry-picked for 3.3.1.

@Calinou Calinou deleted the doc-audiostreamplayer branch August 3, 2021 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AudioStreamPlayer3D still playing audio while parent node is disabled in scene
2 participants