Default to 30 animation fps for better quality. #51341
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It would be nice to amend the commit message to refer explicitly to animation fps. |
fire
changed the title
aaronfranke
approved these changes
Aug 29, 2021
|
I really want to implement animation compression and streaming so 30fps can be made default, but this is a lot of work. The problem with 30fps animation is that right now they take a lot of space. |
This was referenced Oct 15, 2021
|
godotengine/godot-proposals#430 would likely be a better solution for animations designed with a lower framerate. However, this PR can work as a stopgap since many animators use 30 FPS as a baseline. |
|
@reduz animation compression was implemented, as discussed in rocket chat, can you approve on Github? |
reduz
approved these changes
Nov 9, 2021
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reduz mentioned that he was working on animation streaming for Godot Engine. It was unclear when his animation streaming support will be complete and animation streaming is an optimization, so this [animation streaming] feature is unrelated to the bug-fix of animations defaulting to the wrong fps and skipping transforms by under-sampling.