-
-
Notifications
You must be signed in to change notification settings - Fork 21.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Port 2D improvements to move and slide 3D (with extras) #52889
Merged
pouleyKetchoupp
merged 1 commit into
godotengine:master
from
fabriceci:multiple_collision-support-fab
Sep 22, 2021
Merged
Port 2D improvements to move and slide 3D (with extras) #52889
pouleyKetchoupp
merged 1 commit into
godotengine:master
from
fabriceci:multiple_collision-support-fab
Sep 22, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pouleyKetchoupp
suggested changes
Sep 21, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! I've left some comments about details but it generally looks good.
Edit: Also needs a rebase because of recent changes in the documentation.
Co-authored-by: Camille Mohr-Daurat <pouleyketchoup@gmail.com>
fabriceci
force-pushed
the
multiple_collision-support-fab
branch
from
September 21, 2021 22:14
43cf8fa
to
fd9e573
Compare
pouleyKetchoupp
approved these changes
Sep 22, 2021
This was referenced Nov 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks to @pouleyKetchoupp for his help/work on this, as this was harder than I thought. The latest "jitters" are definitively the worst :)
fix #30310
fix #50756
fix #51874
fix #52887
Test project: https://github.com/fabriceci/3d-platform-test-for-godot4 (based on the @TokageItLab one, thanks to him)
This PR should provide a good physics by default for CharacterBody3D, without any effort.
move_and_collide
which allows us to handle advanced cases like the one below in the screenshot when the body is stuck between two walls